Stefan Weber (AH)'s Discussions

Constants in ASM statements

Started Oct 9

Bug in Val() with Floats and fix for it
6 Replies

Started this discussion. Last reply by Stefan Weber (AH) May 27.

View All

Stefan Weber (AH)'s Page

Latest Activity

Stefan Weber (AH) added a discussion

Constants in ASM statements

Hi everyone, I have just found out that constant calculations like this mov esi, offset A - offset B fail with the following error message f:\ndn\source\extsrc\winoldap.dll\WINOLDIF.PAS(860): Error 31: Constant expected The error caret (^) points...

October 9

Stefan Weber (AH) replied to Stefan Weber (AH)'s discussion 'Bug in Val() with Floats and fix for it'

JFYI: TQuad (the VP 64-Bit integer type) is a Comp. VP doesn't know a *real* int64 type.

May 27

Marco van de Voort replied to Stefan Weber (AH)'s discussion 'Bug in Val() with Floats and fix for it'

I could retest this with COMP logic. Maybe that changes, since comp is FPU, and int64 not, it would stress difference part of VAL maybe. I'll pester some Delphi forums with the difference tomorrow, see if they come up with something, and will repo...

May 26

Stefan Weber (AH) replied to Stefan Weber (AH)'s discussion 'Bug in Val() with Floats and fix for it'

Hi Marco, now you are forcing me to look at my fix again. :P Ok, first of all your comparisons all fail because RSa is different from RSb :P Obviously the result of Str() in VP on numbers without digits after the decimal point is different from ...

May 26

Stefan Weber (AH) replied to Stefan Weber (AH)'s discussion 'Bug in Val() with Floats and fix for it'

Hi Allan, I have no objections at all and hope that someone may find it useful. All I can say is that most of the code in mathx is actually used in NDNs calculator, so bugs should be rare. Please read my reply to Marco for some mroe information ...

May 26

Marco van de Voort replied to Stefan Weber (AH)'s discussion 'Bug in Val() with Floats and fix for it'

Is it a bug? I made the following mods trunc64->trunc and commenting the uses line. I also printed RSA and r. Delphi 2006 Comparing values before and after Trunc64() rsa:-1.00000000000000E+0000 r: 0 -1 -> -1 Failed! rsa:-1.00000000000000E+0000 ...

May 25

Allan Mertner replied to Stefan Weber (AH)'s discussion 'Bug in Val() with Floats and fix for it'

Hi Stefan, Thanks for that - that is a tricky corner case! I have tested and included the fix in system.pas. I also looked at your mathx unit, and I think it makes sense to include much of that code in VP's int64 unit. Do you have any objection ...

May 25

Stefan Weber (AH) added a discussion

Bug in Val() with Floats and fix for it

Hi everyone, esp Allan. I just have fixed a rare bug that occurs when using Val() to an Extended type with 30+ digits. This bug occured only when truncating this value to a 64-bit integer. NDN's internal 64-bit calculator has showed this, and tha...

May 17